Re: [HACKERS] BUG #6083: psql script line numbers incorrectly count \copy data

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Steve Haslam <araqnid(at)googlemail(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] BUG #6083: psql script line numbers incorrectly count \copy data
Date: 2011-07-04 19:01:16
Message-ID: 20110704190116.GE29446@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Jul 04, 2011 at 12:02:12PM -0400, Tom Lane wrote:
> "Steve Haslam" <araqnid(at)googlemail(dot)com> writes:
> > ... Apparently, the data read from \copy is incrementing the
> > script line number counter?
>
> Yeah, so it is. That is correct behavior for COPY FROM STDIN, but
> not so much for copying from a separate file.
>
> The attached patch seems like an appropriate fix. However, I'm
> unsure whether to apply it to released branches ... does anyone
> think this might break somebody's application?

No.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message zearth 2011-07-05 01:35:33 BUG #6090: Connection problem
Previous Message Tom Lane 2011-07-04 16:02:12 Re: BUG #6083: psql script line numbers incorrectly count \copy data

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-07-04 19:24:42 Re: avoid including rel.h in execnodes.h
Previous Message Jaime Casanova 2011-07-04 19:00:40 Re: keepalives_* parameters usefullness