Re: avoid including rel.h in execnodes.h

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: avoid including rel.h in execnodes.h
Date: 2011-07-04 19:24:42
Message-ID: 1309807428-sup-7621@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Tom Lane's message of vie jul 01 18:20:50 -0400 2011:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:

> > I also included rel.h in spi.h, because it was previously indirectly
> > included via execnodes.h and with this patch it would no longer be,
> > which is a problem because it'd cause external code to fail to compile.
>
> If we think that not including rel.h unnecessarily is a good thing, then
> that should surely apply to external code as well. So -1 for that bit.
> It's not like we have not removed stuff from spi.h before.

Thanks, committed with that change.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Glaesemann 2011-07-04 19:35:44 Re: non-superuser reserved connections? connection pools?
Previous Message David Fetter 2011-07-04 19:01:16 Re: [HACKERS] BUG #6083: psql script line numbers incorrectly count \copy data