From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Per-column collation, the finale |
Date: | 2011-02-03 23:36:24 |
Message-ID: | 20110203233624.GA18572@tornado.gateway.2wire.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 03, 2011 at 05:53:28PM +0200, Peter Eisentraut wrote:
> On tor, 2011-02-03 at 00:10 -0500, Noah Misch wrote:
> > > This is good stuff. I'll send you a new patch in a day or three for
> > > perhaps another round of performance tests. Some of the other
> > issues
> > > above can perhaps be postponed for follow-up patches.
> >
> > I agree -- if the performance-when-unused gets solid, none of my other
> > comments ought to hold things up.
>
> Here is a new patch.
>
> The main change is in varstr_cmp(), avoiding the calls to
> pg_newlocale_from_collation() when the default locale is used. This
> accounts for the performance regression in my tests. It also addresses
> some of your refactoring ideas.
Looks good and tests well. I've attached the same benchmark script with updated
timings, and I've marked the patch Ready for Committer.
nm
Attachment | Content-Type | Size |
---|---|---|
bench-collate-v2.sql | text/plain | 687 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Joshua D. Drake | 2011-02-03 23:56:57 | Re: [HACKERS] Slow count(*) again... |
Previous Message | Mladen Gogala | 2011-02-03 23:33:21 | Re: [HACKERS] Slow count(*) again... |