From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib |
Date: | 2010-05-12 23:47:03 |
Message-ID: | 201005122347.o4CNl3Q10985@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
bruce wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > All other binaries had such a designation, and all /contrib binaries
> > > were missing them. I assume I was doing cleanup. You want the icon
> > > removed from the backend makefile?
> >
> > Yes. I'm prepared to believe that not having the icons set on the
> > contrib executables was an oversight. I'm much less prepared to assume
> > that not marking the postgres executable was an oversight. Again,
> > unless you *know* that this change is needed and appropriate, now is
> > not the time to be making it, and especially not without discussion.
>
> OK, done with attached patch, and I added a comment about why it is not
> labeled.
I did some research on PGFILEDESC and it does what I thought it does ---
in embeds the 'ico' file into the executable in
/pg/tools/msvc/Project.pm, and the image looks like the attached JPEG.
The image is of a blue elephant head.
So, currently, every binary uses that icon, except for the postmaster.
Is that what we want? You could make the argument that a daemon, like
the postmaster, shouldn't have one, which I think is Tom's point.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
![]() |
image/jpeg | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2010-05-12 23:55:59 | Re: pg_upgrade versus MSVC build scripts |
Previous Message | David E. Wheeler | 2010-05-12 23:11:24 | Re: pg_upgrade versus MSVC build scripts |