| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: should I post the patch as committed? |
| Date: | 2010-04-20 17:11:41 |
| Message-ID: | 20100420171141.GB3229@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian escribió:
> Magnus Hagander wrote:
> > Yeah, +1. I always go to one of the other sources (most of the time,
> > the gitweb or git server).
> >
> > It doesn't hurt to attach it if it happens to be around, but I
> > wouldn't suggest spending any extra effort on it...
>
> Well, many times I am applying a patch from an author that I have
> modified, and I don't expect them to be subscribed to committers, so I
> supply the patch as a courtesy so they can see my changes (and fix
> them). :-)
I think committing a patch from a non-regular is a special case and
attaching the modified patch is reasonable in that case.
My 8.8 Richter ...
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2010-04-20 17:23:51 | Re: BETA |
| Previous Message | Tom Lane | 2010-04-20 17:09:23 | Re: Why does TRIM() expect an expr_list? |