From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pq_setkeepalives* functions |
Date: | 2010-03-13 16:40:46 |
Message-ID: | 201003131640.o2DGelf27362@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Jaime Casanova wrote:
> >> but in pq_setkeepalivesinterval() the #DEFINE is after the
> >> conditional, doesn't seems to affect anything but for consistency with
> >> the other two :)
>
> > Thanks, applied.
>
> This makes the function *not* like the other two, rather than
> improving consistency.
Well, it makes it like some of the existing functions, but not like
others. This applied patch fixes them all.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
Attachment | Content-Type | Size |
---|---|---|
/rtmp/diff | text/x-diff | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-03-13 16:44:21 | Re: pq_setkeepalives* functions |
Previous Message | Tom Lane | 2010-03-13 16:40:35 | Re: Dyamic updates of NEW with pl/pgsql |