| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [COMMITTERS] pgsql: Forbid setval() during recovery. |
| Date: | 2010-02-20 17:33:54 |
| Message-ID: | 201002201833.56969.andres@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Saturday 20 February 2010 17:34:50 Tom Lane wrote:
> heikki(at)postgresql(dot)org (Heikki Linnakangas) writes:
> > Forbid setval() during recovery. This prevents the PANIC reported by
> > Erik Rijkers. Patch by Andres Freund.
>
> ISTM this is the wrong fix. The real bug is that setval() doesn't
> check XactReadOnly. Now XactReadOnly is only a "soft" read only
> mode, but I don't see an argument for either setval() or nextval()
> to be allowed when that's set.
> Any objections to changing that?
Not from my side - sounds more sensible...
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-02-20 18:28:37 | pgsql: Document that many solid-state drives have volatile write-back |
| Previous Message | Tom Lane | 2010-02-20 16:34:50 | Re: [COMMITTERS] pgsql: Forbid setval() during recovery. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-02-20 17:45:24 | Re: PGXS: REGRESS_OPTS=--load-language=plpgsql |
| Previous Message | Dimitri Fontaine | 2010-02-20 16:50:43 | Re: explain and PARAM_EXEC |