Re: [COMMITTERS] pgsql: Forbid setval() during recovery.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Forbid setval() during recovery.
Date: 2010-02-20 16:34:50
Message-ID: 10444.1266683690@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

heikki(at)postgresql(dot)org (Heikki Linnakangas) writes:
> Forbid setval() during recovery. This prevents the PANIC reported by
> Erik Rijkers. Patch by Andres Freund.

ISTM this is the wrong fix. The real bug is that setval() doesn't
check XactReadOnly. Now XactReadOnly is only a "soft" read only
mode, but I don't see an argument for either setval() or nextval()
to be allowed when that's set.

Any objections to changing that?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2010-02-20 17:33:54 Re: [COMMITTERS] pgsql: Forbid setval() during recovery.
Previous Message Simon Riggs 2010-02-20 10:07:27 pgsql: Copy editing of Hot Standby docs.

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-02-20 16:50:43 Re: explain and PARAM_EXEC
Previous Message Jaime Casanova 2010-02-20 16:24:34 Re: explain and PARAM_EXEC