| From: | Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Initial refactoring of plperl.c - updated |
| Date: | 2010-01-10 12:29:32 |
| Message-ID: | 20100110122932.GG2481@timac.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 10, 2010 at 01:16:13AM -0500, Tom Lane wrote:
> Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com> writes:
> > On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
> >> What's the reason for the temp file here?
>
> > Defensive. If the text2macro.pl program fails/dies then you'd be left
> > with a broken output file with a newer timestamp, so the next make
> > wouldn't rerun text2macro.pl.
>
> Doesn't make forcibly remove the target file if the command fails?
>
> [ rummages in manual... ] It does if you specify .DELETE_ON_ERROR,
> which we do (in Makefile.global); so this bit of complication is
> a waste.
Okay.
Andrew, perhaps you could apply the attached to fix that. (Or I could
bundle it into one of the split out plperl feature patches.)
Tim.
| Attachment | Content-Type | Size |
|---|---|---|
| master-fixtext2macro.patch | text/x-patch | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Mansion | 2010-01-10 12:33:45 | Re: win32 socket definition |
| Previous Message | Magnus Hagander | 2010-01-10 12:24:46 | ECPG patch causes warning |