Re: Need --without-docs build switch

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Need --without-docs build switch
Date: 2009-12-10 19:32:57
Message-ID: 20091210193257.GN15554@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
> > On 12/10/09 10:03 AM, Tom Lane wrote:
> >> Josh Berkus <josh(at)agliodbs(dot)com> writes:
> >>> Testing Alpha2 with the Exclusion Constraints patch on Mac recently
> >>> forced me to edit the makefiles to remove the make docs statements.
> >>
> >> How so? The make process does not try to build the docs unless you
> >> specifically tell it to.
>
> > It most certainly did with Alpha2.
>
> Hm, maybe the alpha2 tarball had docs in it already? And they weren't
> up to date? You might be hitting the same thing I've complained of:
> since "make distclean" no longer removes built docs, you can find
> yourself running an update cycle when you didn't want to. Peter
> rejected my opinion that we should go back to the old behavior of
> "make distclean", but I'm still not happy about it.
> http://archives.postgresql.org/pgsql-hackers/2009-08/msg01336.php

If the patch added new docs, then a doc build would be invoked by make.
A "make -C doc maintainer-clean" would remove the trigger files and thus
the docs would not be built after applying the patch.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-12-10 19:45:31 Re: explain output infelicity in psql
Previous Message Kevin Grittner 2009-12-10 19:29:18 Re: tsearch parser inefficiency if text includes urls or emails - new version