From: | Kenneth Marshall <ktm(at)rice(dot)edu> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Another try at reducing repeated detoast work for PostGIS |
Date: | 2009-08-22 19:34:57 |
Message-ID: | 20090822193457.GA4268@it.is.rice.edu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Aug 22, 2009 at 12:39:41PM -0400, Tom Lane wrote:
> Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk> writes:
> > So in conclusion, I think that patch looks good and that the extra time
> > I was seeing was due to RECHECK being applied to the && operator, and
> > not the time being spent within the index scan itself.
>
> Thanks, I appreciate the followup.
>
> I plan to go ahead and apply the patch to HEAD --- it doesn't conflict
> with Heikki's pending patch AFAICS, and no one has suggested an
> alternative that seems likely to get implemented soon.
>
> I am a bit tempted to apply it to 8.4 as well; otherwise the PostGIS
> people are likely to start cluttering their code with this
> add-a-dummy-function workaround, which would be unproductive in the long
> run. Comments?
>
> regards, tom lane
>
+1 for applying it to 8.4 as well.
Cheers,
Ken
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-08-22 20:01:53 | Re: Index-only quals |
Previous Message | Heikki Linnakangas | 2009-08-22 19:18:39 | Re: Resjunk sort columns, Heikki's index-only quals patch, and bug #5000 |