| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Another try at reducing repeated detoast work for PostGIS |
| Date: | 2009-08-22 16:39:41 |
| Message-ID: | 10470.1250959181@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk> writes:
> So in conclusion, I think that patch looks good and that the extra time
> I was seeing was due to RECHECK being applied to the && operator, and
> not the time being spent within the index scan itself.
Thanks, I appreciate the followup.
I plan to go ahead and apply the patch to HEAD --- it doesn't conflict
with Heikki's pending patch AFAICS, and no one has suggested an
alternative that seems likely to get implemented soon.
I am a bit tempted to apply it to 8.4 as well; otherwise the PostGIS
people are likely to start cluttering their code with this
add-a-dummy-function workaround, which would be unproductive in the long
run. Comments?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Caleb Welton | 2009-08-22 16:44:00 | Re: [PATCH] plpythonu datatype conversion improvements |
| Previous Message | Roger Leigh | 2009-08-22 16:38:16 | Submitted patches stuck in moderation queue |