Re: [PATCH] Psql List Languages

From: Fernando Ike de Oliveira <fike(at)midstorm(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Psql List Languages
Date: 2009-07-15 21:38:31
Message-ID: 20090715183831.21cc603a@darkside
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em Thu, 02 Jul 2009 15:27:33 -0400
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> escreveu:

> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Looks good, but needs documentation and tab-complete.c updates, it
> > seems. And you should revisit this patch to make it consistent
> > with the S flag that was added to most \d commands. For example,
> > \dL would show only user-added languages, but \dLS would include c,
> > internal, and sql.
>
> Another recent change in the \d support is that commands are expected
> to work (as best they can) for all server versions back to 7.4. I
> didn't look to see if this patch needs any fixes for that, but it's
> something to keep in mind while reviewing.

I applied the Tom Lane and Peter considerations, but I had that
remove one column (Owner) of out command \dL to compatibility with 7.4
version. The command \dLS output:

test=# \dLS
List of languages
Name | Procedural Language | Trusted | Call Handler |
Validator
----------+---------------------+-----------+----------------------+
-------------------------
c | Untrusted | Untrusted | |
fmgr_c_validator
internal | Untrusted | Untrusted | |
fmgr_internal_validator
plperl | Trusted | Trusted | plperl_call_handler |
plperl_validator
plpgsql | Trusted | Trusted | plpgsql_call_handler |
plpgsql_validator
pltcl | Trusted | Trusted | pltcl_call_handler |

sql | Untrusted | Trusted | |
fmgr_sql_validator
(6 rows)

test=#

Comments?

Best Regards,
--
Fernando Ike

Attachment Content-Type Size
psql_list_lang_v3.patch text/x-patch 5.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2009-07-15 21:59:34 Re: Synch Rep for CommitFest 2009-07
Previous Message Jamie Fox 2009-07-15 21:22:49 Re: [GENERAL] large object does not exist after pg_migrator