Re: Allow COMMENT ON to accept an expression rather than just a string

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Abhijit Menon-Sen <ams(at)oryx(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow COMMENT ON to accept an expression rather than just a string
Date: 2009-04-11 17:15:50
Message-ID: 200904111715.n3BHFoZ11347@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Abhijit Menon-Sen <ams(at)oryx(dot)com> writes:
> > There's a TODO item about making COMMENT ON accept an expression. The
> > grammar change is simple (SConst|NULL_P->a_expr), but as far as I can
> > see, there are no similar utility commands that take expressions, and
> > I'm not very familiar with the planner and executor, so I could use
> > some advice about how to evaluate the expression.
>
> There aren't *any* utility commands that take expressions, and I would
> say that that TODO item is seriously mis-scoped. What is the use of
> making COMMENT in particular do this? Fixing all of them might be
> interesting.

I remember adding the TODO after a request from the user, but I have not
seen further requests. I have remove the item; let's see if we get any
further requests for it.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2009-04-11 17:21:41 Re: Patch for 8.5, transformationHook
Previous Message Tom Lane 2009-04-11 17:07:43 Re: Crash in gist insertion on pathological box data