| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Date: | 2009-02-11 18:03:54 |
| Message-ID: | 20090211180354.GJ8924@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > This version should fix these issues. I refrained from adding more ? :
> > expressions because it starts getting ugly for my taste.
>
> I think you might as well just introduce two separate code paths to
> produce the 8.4 and pre-8.4 queries, so that you don't need the LEFT
> JOIN in the pre-8.4 path.
Right, see attached. (Separating the last two cases is probably
overkill ...?) I tested with HEAD, 8.2 and 8.0, seems to work fine.
> IMHO the cut-and-paste way that we usually
> do it in pg_dump is a whole lot easier to read and maintain than this
> sort of ?: spaghetti.
Hmm, so should we try to get rid of them in a more consistent fashion?
| Attachment | Content-Type | Size |
|---|---|---|
| psql-toast-relopts-3.patch | text/x-diff | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-02-11 18:39:10 | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Previous Message | Tom Lane | 2009-02-11 17:34:25 | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-02-11 18:10:46 | Re: temporarily stop autovacuum |
| Previous Message | Joshua D. Drake | 2009-02-11 17:59:22 | Re: temporarily stop autovacuum |