| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Date: | 2009-02-11 17:34:25 |
| Message-ID: | 11418.1234373665@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> This version should fix these issues. I refrained from adding more ? :
> expressions because it starts getting ugly for my taste.
I think you might as well just introduce two separate code paths to
produce the 8.4 and pre-8.4 queries, so that you don't need the LEFT
JOIN in the pre-8.4 path. IMHO the cut-and-paste way that we usually
do it in pg_dump is a whole lot easier to read and maintain than this
sort of ?: spaghetti.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-02-11 18:03:54 | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Previous Message | User Achernow | 2009-02-11 15:03:36 | libpqtypes - libpqtypes: Fixed empty array issue, getf always returned a |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2009-02-11 17:43:18 | Re: Optimization rules for semi and anti joins |
| Previous Message | Tom Lane | 2009-02-11 17:28:32 | Re: Optimization rules for semi and anti joins |