Re: DTrace probes patch

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Robert Lor <Robert(dot)Lor(at)Sun(dot)COM>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DTrace probes patch
Date: 2008-12-17 17:25:50
Message-ID: 20081217172550.GH4453@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Lor escribió:
> Fujii Masao wrote:
>> Hi,
>>
>> On Wed, Dec 17, 2008 at 4:53 AM, Robert Lor <Robert(dot)Lor(at)sun(dot)com> wrote:

>> Why is TRACE_POSTGRESQL_WAL_BUFFER_WRITE_START/DONE called
>> only in AdvanceXLInsertBuffer? We can trace only a part of WAL buffer write?
>>
> The intention of these probes is to determine if wal_buffers is too
> small by monitoring how frequent the server has to write out the buffers
> along with the I/O time.

But there are 5 callers of XLogWrite ... why aren't the other ones being
tracked too?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2008-12-17 17:43:10 Re: Variadic parameters vs parameter defaults
Previous Message Robert Lor 2008-12-17 17:15:51 Re: DTrace probes patch