| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kris Jurka <books(at)ejurka(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: don't use MAKE_PTR/OFFSET for shmem pointers |
| Date: | 2008-11-03 14:48:52 |
| Message-ID: | 20081103144852.GF4509@alvh.no-ip.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Kris Jurka <books(at)ejurka(dot)com> writes:
> > Since we require every process to map the shared memory region to the same
> > address, we don't need the MAKE_PTR/OFFSET code that was needed when that
> > was not the case. This patch makes shared memory pointers just like
> > regular pointers.
>
> Applied with minor editorialization --- mainly, I converted a couple of
> "void *" pointer declarations to more specific types, since it seems to
> me the main point of this is to not use nonspecific pointers
> unnecessarily.
We now have two very similar doubly-linked list implementations. Should
we take one of them out?
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-11-03 15:02:36 | Re: pre-MED |
| Previous Message | David Fetter | 2008-11-03 14:32:06 | Re: pre-MED |