Re: don't use MAKE_PTR/OFFSET for shmem pointers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: don't use MAKE_PTR/OFFSET for shmem pointers
Date: 2008-11-02 21:27:19
Message-ID: 16309.1225661239@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kris Jurka <books(at)ejurka(dot)com> writes:
> Since we require every process to map the shared memory region to the same
> address, we don't need the MAKE_PTR/OFFSET code that was needed when that
> was not the case. This patch makes shared memory pointers just like
> regular pointers.

Applied with minor editorialization --- mainly, I converted a couple of
"void *" pointer declarations to more specific types, since it seems to
me the main point of this is to not use nonspecific pointers
unnecessarily.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonah H. Harris 2008-11-02 21:49:24 WIP: Hash Join-Filter Pruning using Bloom Filters
Previous Message Heikki Linnakangas 2008-11-02 20:25:51 Re: [COMMITTERS] pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and