| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Andrew Chernow <ac(at)esilo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: libpq Win32 Mutex performance patch |
| Date: | 2008-05-13 20:21:08 |
| Message-ID: | 20080513202108.GN6966@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Magnus Hagander wrote:
> Alvaro Herrera wrote:
> > Andrew Chernow wrote:
> > > Tom Lane wrote:
> > >> Silently not locking is surely
> > >> not very safe.
> > >>
> > >
> > > Here is the dump code version of the patch. If anyone wants the
> > > return value idea, let me know.
> >
> > So is this a patch we want applied?
>
> Please see my other thread about libpq thread-locking which should be
> finished before this one, after which this patch will change. So no,
> this is not the version to be applied.
Hmm, AFAICT on that other thread you state
> I'm leaning towards going with the simpler one, which is the patch
> from Andrew that crashes on out of memory.
which would seem to mean this patch?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2008-05-13 20:53:33 | Re: Making sure \timing is on |
| Previous Message | Magnus Hagander | 2008-05-13 20:14:48 | Re: libpq Win32 Mutex performance patch |