| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Trevor Talbot <quension(at)gmail(dot)com>, Zeugswetter Andreas ADI SD <Andreas(dot)Zeugswetter(at)s-itsolutions(dot)at>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgwin32_open returning EINVAL |
| Date: | 2007-12-20 15:26:41 |
| Message-ID: | 20071220152641.GB26753@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 20, 2007 at 10:11:10AM -0500, Tom Lane wrote:
> "Trevor Talbot" <quension(at)gmail(dot)com> writes:
> > Without looking myself, is it possible for errhint() or errdetail() to
> > do something that affects GetLastError()?
>
> Hmm ... the macro framework is designed so that the arguments get
> evaluated before anything very interesting happens, but it might be
> better to use a variable anyway --- for onm thing we could get rid of
> the redundant GetLastError calls in the test in front of this.
I'd expect the compiler to optimize away those, but I'll make it a var
anyawy.
> BTW, I concur with Martijn's comment to avoid constructing phrases from
> spare parts; it creates a translation problem, and in this case you'd
> only be saving a few bytes anyway.
Ok. Are you saying whole sentence, or are you saying it's fine to just
break out the part that's after the colon into "sharing violation" and
"lock violation"? I assume the second?
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-12-20 15:26:46 | Re: pgwin32_open returning EINVAL |
| Previous Message | Tom Lane | 2007-12-20 15:11:10 | Re: pgwin32_open returning EINVAL |