| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Trevor Talbot" <quension(at)gmail(dot)com> |
| Cc: | "Magnus Hagander" <magnus(at)hagander(dot)net>, "Zeugswetter Andreas ADI SD" <Andreas(dot)Zeugswetter(at)s-itsolutions(dot)at>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgwin32_open returning EINVAL |
| Date: | 2007-12-20 15:11:10 |
| Message-ID: | 11200.1198163470@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Trevor Talbot" <quension(at)gmail(dot)com> writes:
> Without looking myself, is it possible for errhint() or errdetail() to
> do something that affects GetLastError()?
Hmm ... the macro framework is designed so that the arguments get
evaluated before anything very interesting happens, but it might be
better to use a variable anyway --- for onm thing we could get rid of
the redundant GetLastError calls in the test in front of this.
BTW, I concur with Martijn's comment to avoid constructing phrases from
spare parts; it creates a translation problem, and in this case you'd
only be saving a few bytes anyway.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-12-20 15:26:41 | Re: pgwin32_open returning EINVAL |
| Previous Message | Koichi Suzuki | 2007-12-20 14:53:36 | Re: Benchmark for GiST index? |