From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Fix mdsync never-ending loop problem |
Date: | 2007-04-05 13:45:24 |
Message-ID: | 20070405134524.GB8578@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
While skimming over this I was baffled a bit about the usage of
(InvalidBlockNumber - 1) as value for FORGET_DATABASE_FSYNC. It took me
a while to realize that this code is abusing the BlockNumber typedef to
pass around *segment* numbers, so the useful range is much smaller and
thus the usage of that value is not a problem in practice.
I wonder if it wouldn't be better to clean this up by creating a
separate typedef for segment numbers, with its own special values?
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-04-05 13:54:29 | Re: Buildfarm failures en masse |
Previous Message | Bruce Momjian | 2007-04-05 13:30:06 | Re: Buildfarm failures en masse |
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2007-04-05 14:21:42 | Re: Load distributed checkpoint V3 |
Previous Message | Greg Smith | 2007-04-05 13:05:53 | Re: Load distributed checkpoint V3 |