Re: XML changes broke assert-enabled vcbuild

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: XML changes broke assert-enabled vcbuild
Date: 2007-02-13 15:40:45
Message-ID: 20070213154045.GA12830@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 13, 2007 at 04:29:16PM +0100, Magnus Hagander wrote:
> The latest set of XML changes (I think latest, at least fairly recent)
> broke the win32vc build with asserts enabled. The line:
> Assert(fully_escaped || !escape_period);
>
> From what I can tell, this is because the Assert() puts code (the do {}
> loop) *before* the declaration of StringInfoData buf, which is not
> permitted.
>
> Attached patch seems to fix this. Can someone confirm this is correct
> before I put it in?

I just realised I should of course move the comment as well :-) Thus,
the attached patch is more correct.

//Magnus

Attachment Content-Type Size
xml.patch text/plain 1.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-02-13 15:43:30 Re: Variable length varlena headers redux
Previous Message Pavan Deolasee 2007-02-13 15:37:16 Re: HOT for PostgreSQL 8.3