Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Jim Nasby <decibel(at)decibel(dot)org>, Zeugswetter Andreas ADI SD <ZeugswetterA(at)spardat(dot)at>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off
Date: 2007-01-12 10:09:28
Message-ID: 20070112100928.GA6589@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Thu, Jan 11, 2007 at 11:10:38PM +0000, Simon Riggs wrote:
> On Thu, 2007-01-11 at 17:06 +0000, Gregory Stark wrote:
> > Having a CRC in WAL but not in the heap seems kind of pointless.
>
> Yes...
>
> > If your
> > hardware is unreliable the corruption could anywhere.
>
> Agreed.

I thought the point was that the WAL protects against unexpected power
failure, that sort of thing. In that situation, the memory is the first
to be corrupted, and an active DMA transfer will thus be corrupted
also. We don't need to worry about the data, because the WAL is known
to be accurate.

The WAL does not protect against random data corruption, in normal
operation it is never read. If we want to detect random corruption,
we'd need checksum everywhere, yes. But that's not the goal here.

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2007-01-12 10:35:48 Re: O_DIRECT, or madvise and/or posix_fadvise
Previous Message Michael Meskes 2007-01-12 09:55:01 Re: [COMMITTERS] pgsql: Stamp major release 8.3.0,

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-12 13:55:52 Re: Corrupt database? 8.1/FreeBSD6.0
Previous Message Guillaume Smet 2007-01-12 09:46:41 Re: [PATCHES] Patch to log usage of temporary files