Re: pgsql: Allow pg_resetxlog -f to reset pg_control

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <momjian(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow pg_resetxlog -f to reset pg_control
Date: 2006-04-26 18:56:17
Message-ID: 200604261856.k3QIuH017761@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs wrote:
>
> It appears to me that a line like this has been missed out for when
> mode==GUESS
>
> ControlFile.checkPointCopy.ThisTimeLineID = 2;
>
> (search for 514...)
>
> The old line which guessed at
> ControlFile.checkPointCopy.ThisTimeLineID = 1;
> has been removed, but with nothing to replace it, except in WAL mode.
>
> I'd prefer to guess the TLI as 2, since that is usually one more than
> where we got to previously, and much more likely to be a reasonable
> value choice.

Good analysis. I cleaned up that section and added the line you
suggested.

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
unknown_filename text/plain 3.1 KB

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2006-04-26 18:56:56 pgsql: Add missing ControlFile.checkPointCopy.ThisTimeLineID line for
Previous Message Bruce Momjian 2006-04-26 18:30:10 pgsql: Update catalog version for ltree changes.