Re: pgsql: Allow pg_resetxlog -f to reset pg_control

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Bruce Momjian <momjian(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow pg_resetxlog -f to reset pg_control
Date: 2006-04-26 18:01:04
Message-ID: 1146074464.3120.32.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


It appears to me that a line like this has been missed out for when
mode==GUESS

ControlFile.checkPointCopy.ThisTimeLineID = 2;

(search for 514...)

The old line which guessed at
ControlFile.checkPointCopy.ThisTimeLineID = 1;
has been removed, but with nothing to replace it, except in WAL mode.

I'd prefer to guess the TLI as 2, since that is usually one more than
where we got to previously, and much more likely to be a reasonable
value choice.

On Tue, 2006-04-25 at 23:17 -0300, Bruce Momjian wrote:
> Log Message:
> -----------
> Allow pg_resetxlog -f to reset pg_control counters using xlog
> information, and add a -r option to reset pg_control without affecting
> xlog.

> pgsql/src/bin/pg_resetxlog:
> pg_resetxlog.c (r1.43 -> r1.44)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_resetxlog/pg_resetxlog.c.diff?r1=1.43&r2=1.44)
>

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2006-04-26 18:28:36 pgsql: Enhanced containment selectivity function for /contrib/ltree
Previous Message Bruce Momjian 2006-04-26 02:17:15 pgsql: Allow pg_resetxlog -f to reset pg_control counters using xlog