Two coverity non-bugs

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: pgsql-patches(at)postgresql(dot)org
Subject: Two coverity non-bugs
Date: 2006-04-19 12:02:54
Message-ID: 20060419120254.GH15420@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Attached is a patch that fixes two non-bugs. There's plenty of
redundant NULL checks around the place but these were just so silly I
figure they're worth fixing.

The first checks 'file' the line after having dereferenced it. The
second checks 'currSchema' where the code is designed to never allow it
to be NULL.

Currently they've fixed the bogus errors relating to elog(), but not yet
the ones relating to ereport(). There's still mountains of crap to wade
through and not a single real bug found yet.

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

Attachment Content-Type Size
useless.diff text/plain 1.3 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-04-19 14:15:54 Re: bug in windows xp
Previous Message Martijn van Oosterhout 2006-04-19 10:20:06 Re: bug in windows xp