| From: | Michael Fuhr <mike(at)fuhr(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Strange interval arithmetic |
| Date: | 2005-11-30 22:18:23 |
| Message-ID: | 20051130221823.GA27181@winnie.fuhr.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Wed, Nov 30, 2005 at 07:06:42PM -0300, Alvaro Herrera wrote:
> Hmm, why not check both the return value _and_ errno:
>
> val = strtol(field[i], &cp, 10);
> if (val == LONG_MAX && errno == ERANGE)
> return DTERR_FIELD_OVERFLOW;
I usually check both in my own code but I noticed several places
where PostgreSQL doesn't, so I kept that style. I'll check both
if that's preferred.
--
Michael Fuhr
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-11-30 22:20:54 | Re: Strange interval arithmetic |
| Previous Message | Alvaro Herrera | 2005-11-30 22:06:42 | Re: Strange interval arithmetic |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-11-30 22:20:54 | Re: Strange interval arithmetic |
| Previous Message | Alvaro Herrera | 2005-11-30 22:06:42 | Re: Strange interval arithmetic |