From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | "Brian A(dot) Seklecki" <lavalamp(at)spiritual-machines(dot)org> |
Cc: | FC <qqa-1a89(at)myamail(dot)com>, netbsd-help(at)netbsd(dot)org, pgsql-ports(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Darwin compile fixes |
Date: | 2005-10-13 04:02:56 |
Message-ID: | 200510130402.j9D42uc14608@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-ports |
Brian A. Seklecki wrote:
> On Sun, 2005-10-09 at 10:36, Brian A. Seklecki wrote:
> > Is libpq.dylib getting built? Is it there and just not being found? If
> > so, you may need the LDFLAGS/CFLAGS settings from:
> >
> > http://darwinports.opendarwin.org/darwinports/dports/databases/postgresql8/Portfile
> >
> > If it's not being built, capture a log with 'script' and submit a
> > send-pr(1)
> >
>
>
> Also some interesting things at:
Attached is a cleaned up version of the patch (without wrapping). The
change is to use "$(CXX) $(CFLAGS)" instead of $(COMPILER). Does this
change break OS/X?
Also, we use some weird code in main.c:
/*
* Now dispatch to one of PostmasterMain, PostgresMain, GucInfoMain,
* SubPostmasterMain, or BootstrapMain depending on the program name
* (and possibly first argument) we were called with. The lack of
* consistency here is historical.
*/
len = strlen(argv[0]);
if ((len >= 10 && strcmp(argv[0] + len - 10, "postmaster") == 0)
#ifdef WIN32
|| (len >= 14 && strcmp(argv[0] + len - 14, "postmaster.exe") ==
0)
#endif
I think we should be using get_progname() here.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2005-10-13 04:06:24 | Re: Minor point about contrib/xml2 functions "IMMUTABLE" |
Previous Message | Tom Lane | 2005-10-13 03:49:47 | Re: [COMMITTERS] pgsql: Do all accesses to shared buffer headers through |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-10-13 04:28:56 | Re: [HACKERS] Darwin compile fixes |
Previous Message | HS | 2005-10-13 03:53:23 | Re: compilation problem |