| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | "Brian A(dot) Seklecki" <lavalamp(at)spiritual-machines(dot)org>, FC <qqa-1a89(at)myamail(dot)com>, netbsd-help(at)netbsd(dot)org, pgsql-ports(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Darwin compile fixes |
| Date: | 2005-10-13 04:28:56 |
| Message-ID: | 17543.1129177736@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-ports |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Attached is a cleaned up version of the patch (without wrapping). The
> change is to use "$(CXX) $(CFLAGS)" instead of $(COMPILER). Does this
> change break OS/X?
Since our configure doesn't define CXX, I'm having a hard time imagining
how it could fail to break it.
If we *did* define CXX, it would presumably point to g++, which would
also break things since our source code is not C++ clean.
Even more to the point, Darwin isn't broken now --- at least it works
fine on the powerbook I'm typing this on, and on the several OSX
machines in the buildfarm.
I would like to know what this patch is alleged to fix before even
considering applying it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-10-13 05:01:36 | Re: A costing analysis tool |
| Previous Message | Tom Lane | 2005-10-13 04:11:54 | Re: pgsql: Do all accesses to shared buffer headers |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-10-13 15:50:22 | Re: [HACKERS] Darwin compile fixes |
| Previous Message | Bruce Momjian | 2005-10-13 04:02:56 | Darwin compile fixes |