Re: [PATCHES] Patch to add version numbers to

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] Patch to add version numbers to
Date: 2004-12-19 02:16:30
Message-ID: 200412190216.iBJ2GUj10171@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches


Applied, version attached. Magnus tested it.

---------------------------------------------------------------------------

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > + # Force rebuild on re-run of configure
> > > + $(srcdir)/libpq.rc: $(top_srcdir)/src/Makefile.global libpq.rc.in
> > > + sed -e 's/\(VERSION.*\),0 *$$/\1,'`date '+%y%j'`'/' < $< > $@
> >
> > Put Makefile.global second, else $< refers to the wrong file.
> > Also, it has to be $(top_builddir)/src/Makefile.global, not top_srcdir.
> > The comment would probably be more useful if a little more verbose:
> > # depend on Makefile.global to force rebuild on re-run of configure
>
> OK, new version attached with adjustments. I do like the
> Makefile.global dependency idea!
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania 19073

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 5.3 KB

In response to

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Magnus Hagander 2004-12-19 15:50:16 Re: [PERFORM] scalability issues on win32
Previous Message Magnus Hagander 2004-12-17 11:57:10 Re: Problem getting PostgreSQL 8 Beta5 start on localhost port 5432

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-12-19 04:37:23 Re: (8.1) to_timestamp correction (epoch to timestamptz)
Previous Message Tom Lane 2004-12-18 19:31:15 Proposed patch for psql backtick safety