Re: [PATCHES] Patch to add version numbers to

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] Patch to add version numbers to
Date: 2004-12-17 01:44:52
Message-ID: 200412170144.iBH1iqn10156@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > + # Force rebuild on re-run of configure
> > + $(srcdir)/libpq.rc: $(top_srcdir)/src/Makefile.global libpq.rc.in
> > + sed -e 's/\(VERSION.*\),0 *$$/\1,'`date '+%y%j'`'/' < $< > $@
>
> Put Makefile.global second, else $< refers to the wrong file.
> Also, it has to be $(top_builddir)/src/Makefile.global, not top_srcdir.
> The comment would probably be more useful if a little more verbose:
> # depend on Makefile.global to force rebuild on re-run of configure

OK, new version attached with adjustments. I do like the
Makefile.global dependency idea!

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 3.5 KB

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Andrew Dunstan 2004-12-17 03:26:38 Re: [PERFORM] scalability issues on win32
Previous Message Tom Lane 2004-12-17 01:20:43 Re: [PATCHES] Patch to add version numbers to libpq.rc

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-12-17 02:26:09 Re: [FIX] Fix for pgxs on darwin and other platforms...
Previous Message Sean Chittenden 2004-12-17 01:43:44 [FIX] Fix for pgxs on darwin and other platforms...