pgsql: That's just the lovely way windows handles a "segfault".

From: momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: That's just the lovely way windows handles a "segfault".
Date: 2004-11-01 19:22:17
Message-ID: 20041101192217.B91C63A3CBB@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
That's just the lovely way windows handles a "segfault". Gotta be really
interesting for MS to catch all those dumps...

Anyway. Oops. Seems I ran my regression tests with the old psql, and
just managed to update the backend, when I tested that patch. Turns out
there are codepaths where we'd access the Critical Section before it was
initialized. Attached patch breaks the initializeation off to a separate
part and adds that one to a much earlier position in the program.

Magnus Hagander

Modified Files:
--------------
pgsql/src/bin/psql:
common.c (r1.93 -> r1.94)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/common.c.diff?r1=1.93&r2=1.94)
common.h (r1.40 -> r1.41)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/common.h.diff?r1=1.40&r2=1.41)
startup.c (r1.104 -> r1.105)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/startup.c.diff?r1=1.104&r2=1.105)

Browse pgsql-committers by date

  From Date Subject
Next Message User Dpage 2004-11-01 21:09:34 pginstaller - pginst: Write the bindir path for pgAdmin to pick up.
Previous Message Tom Lane 2004-11-01 14:39:21 Re: pgsql: Clarify coding of .exe patch