| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Clarify coding of .exe patch |
| Date: | 2004-11-01 14:39:21 |
| Message-ID: | 13208.1099319961@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Neil Conway <neilc(at)samurai(dot)com> writes:
> Regarding __builtin_constant_p(), it is obviously the case that we need
> to ensure the code compiles on a wide variety of C compilers. But I
> don't see the harm in using GCC-specific features where (a) they can be
> easily #ifdef'd away when not using GCC (b) they have a very limited
> impact -- i.e. they do not result in using a lot of #ifdefs, or
> significantly changing the behavior of the code.
No argument on either of those --- just on the conclusion that we can
optimize on the assumption that that optimization will happen.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-11-01 19:22:17 | pgsql: That's just the lovely way windows handles a "segfault". |
| Previous Message | Bruce Momjian | 2004-11-01 14:33:12 | pgsql: Update comment to point to proper file. |