Re: Some patches to enhance the contrib build

(Sorry if you get thise message twice; the first time I accidentially
used my @debian.org address, which is not subscribed).

Hi Neil!

Neil Conway [2004-11-01 14:06 +1100]:
> BTW, the information in postgresql-7.4.6/debian/copyright is out of date
> (old download URL, old PostgreSQL copyright dates & the regex copyright
> should be updated per the license in src/backend/regex/COPYRIGHT).

Oh, thanks for that hint. Fixed in arch head.

> 20pg_dump_datestyle seems redundant (we already set DateStyle to ISO in
> pg_dump).
>
> > 25contrib-dbmirror:
> > - additionally install some useful scripts and data files
>
> Makes sense to me, although I won't claim to be a dbmirror user. I'll
> apply this to HEAD unless anyone objects.

I do not use it myself, but adding a few scripts to the installation
does not break anything and it was found useful by an user.

> > 25contrib-enablexml:
> > - enable xml module build
> > - Makefile: add CFLAGS for "-I/usr/include/libxml2" to allow building
>
> ISTM the right fix is to use xml2-config.

Right, replacing the -I option with `xml2-config --cflags` works fine
and seems to be more portable. Fixed in arch head.

> > 25contrib-enablemysql:
> > - enable mysql module build
> > - add Makefile
> > - fix hashbang of mysql2pgsql
> >
> > 25contrib-enableoracle:
> > - enable oracle module build
> > - add Makefile
> > - patch ora2pg.pl to look for Ora2Pg.pm additionally in the path
> > where ora2pg.pl is installed
> >
> > 26dbf2pg-errorcheck:
> > - add better error checking to dbf2pg
> >
> > 27dbf2pg-textfield:
> > - add dbf2pg support for the dbase field 'M' which corresponds to
> > PostgreSQL's TEXT field
>
> I can't find these patches in this diff:>
> http://ftp.debian.org/debian/pool/main/p/postgresql/postgresql_7.4.6-2.diff.gz
>
> could you tell me where to find them?

Right now only in arch head:
http://arch.debian.org/arch/pkg-postgresql/postgresql/

The three 25contrib* were split out of the 25contrib patch currently
in 7.4.6-2. The dbf2pg patches were added by me yesterday. I will
probably make a new upload soon, though.

Thanks for considering and have a nice day!

Martin

--
Martin Pitt http://www.piware.de
Ubuntu Developer http://www.ubuntulinux.org
Debian GNU/Linux Developer http://www.debian.org