Re: Some patches to enhance the contrib build

From: Martin Pitt <martin(at)piware(dot)de>
To: PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>, pkg-postgresql-public(at)lists(dot)alioth(dot)debian(dot)org
Subject: Re: Some patches to enhance the contrib build
Date: 2004-11-01 08:11:32
Message-ID: 20041101081131.GC25287@box79162.elkhouse.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi again!

Martin Pitt [2004-11-01 9:04 +0100]:
> Neil Conway [2004-11-01 14:06 +1100]:
> > 20pg_dump_datestyle seems redundant (we already set DateStyle to ISO in
> > pg_dump).

I will look at this and remove it if appropriate. Thanks for the hint.

> > ISTM the right fix is to use xml2-config.
>
> Right, replacing the -I option with `xml2-config --cflags` works fine
> and seems to be more portable. Fixed in arch head.

BTW, I actually used

CFLAGS += $(shell xml2-config --cflags)

in the current patch. I do not really know which is more portable,
using backticks to call xml2-config at compiler invocation time, or
using the $(shell ) syntax which seems GNU make specific. Both wors,
your choice :-)

Martin
--
Martin Pitt http://www.piware.de
Ubuntu Developer http://www.ubuntulinux.org
Debian GNU/Linux Developer http://www.debian.org

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Martin Pitt 2004-11-01 08:17:38 Re: Some patches to enhance the contrib build
Previous Message Tom Lane 2004-11-01 03:45:12 Re: Some patches to enhance the contrib build