Re: [HACKERS] CVS tip problems

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: olly(at)lfix(dot)co(dot)uk, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] CVS tip problems
Date: 2004-06-08 01:46:30
Message-ID: 200406080146.i581kUq08212@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I assume all the callers have to check for NULL,
>
> Eh? *None* of the callers of pqStrerror check for NULL, and I don't
> think they should have to. We surely do not check for null return from
> plain strerror() anyplace.

Oh, I see. It should be like strerror(). Makes sense. I replaced NULL
with "Unknown error" which is what strerror does for an unknown error
number.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2004-06-08 02:18:59 vacuumdb: vacuuming of database "testdonors" failed: ERROR: invalid memory alloc request size 3221225472
Previous Message Chris Travers 2004-06-08 00:44:39 Re: CREATE DATABASE on the heap with PostgreSQL?

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2004-06-08 07:55:32 Re: Relocatable locale
Previous Message Tom Lane 2004-06-07 23:00:51 Re: [HACKERS] CVS tip problems