From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql-server: I think I've finally identified the cause of the |
Date: | 2004-05-31 18:32:23 |
Message-ID: | 20040531183223.85AC1D1B189@svr1.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
I think I've finally identified the cause of the off-by-one-second
issue in timestamp conversion that we hacked around for so long by
ignoring the seconds field from localtime(). It's simple: you have
to watch out for platform-specific roundoff error when reducing a
possibly-fractional timestamp to integral time_t form. In particular
we should subtract off the already-determined fractional fsec field.
This should be enough to get an exact answer with int64 timestamps;
with float timestamps, throw in a rint() call just to be sure.
Tags:
----
REL7_4_STABLE
Modified Files:
--------------
pgsql-server/src/backend/utils/adt:
timestamp.c (r1.96 -> r1.96.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/adt/timestamp.c.diff?r1=1.96&r2=1.96.2.1)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-05-31 18:42:41 | pgsql-server: Too few parens for my taste in this macro. |
Previous Message | Tom Lane | 2004-05-31 18:31:51 | pgsql-server: I think I've finally identified the cause of the |