From: | tgl(at)svr1(dot)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql-server: I think I've finally identified the cause of the |
Date: | 2004-05-31 18:31:51 |
Message-ID: | 20040531183151.DCE46D1B18C@svr1.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
I think I've finally identified the cause of the off-by-one-second
issue in timestamp conversion that we hacked around for so long by
ignoring the seconds field from localtime(). It's simple: you have
to watch out for platform-specific roundoff error when reducing a
possibly-fractional timestamp to integral time_t form. In particular
we should subtract off the already-determined fractional fsec field.
This should be enough to get an exact answer with int64 timestamps;
with float timestamps, throw in a rint() call just to be sure.
Modified Files:
--------------
pgsql-server/src/backend/utils/adt:
timestamp.c (r1.106 -> r1.107)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/adt/timestamp.c.diff?r1=1.106&r2=1.107)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-05-31 18:32:23 | pgsql-server: I think I've finally identified the cause of the |
Previous Message | Bruce Momjian | 2004-05-31 17:57:31 | pgsql-server: Have pg_ctl print pid and error on signal failure, per |