From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Relocatable locale |
Date: | 2004-05-25 01:41:46 |
Message-ID: | 200405250141.i4P1fkg29764@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I have two questions. First, setlocale() seemed to be inconsistently
> > set inside and outside of ENABLE_NLS. I assume the proper location is
> > inside.
>
> Please do *not* go adding setlocale calls that were not there before.
> You *will* break things.
>
> > ! setlocale(LC_ALL, "");
> ^^^^^^^^^^^^^^^^^^^^^
>
> Putting this call in the backend is a very serious mistake. It might be
> okay in clients, but not in the backend.
OK, patch applied. Turns out it was only added for the backend
("postgres").
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 722 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-05-25 01:47:53 | Re: Relocatable locale |
Previous Message | Tom Lane | 2004-05-25 01:29:30 | Re: Relocatable locale |