Re: Relocatable locale

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Relocatable locale
Date: 2004-05-25 01:29:30
Message-ID: 16158.1085448570@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I have two questions. First, setlocale() seemed to be inconsistently
> set inside and outside of ENABLE_NLS. I assume the proper location is
> inside.

Please do *not* go adding setlocale calls that were not there before.
You *will* break things.

> ! setlocale(LC_ALL, "");
^^^^^^^^^^^^^^^^^^^^^

Putting this call in the backend is a very serious mistake. It might be
okay in clients, but not in the backend.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-25 01:41:46 Re: Relocatable locale
Previous Message Bruce Momjian 2004-05-25 00:59:28 Relocatable locale