Re: Add error-checking to timestamp_recv

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Add error-checking to timestamp_recv
Date: 2004-05-20 15:59:09
Message-ID: 200405201559.i4KFx9117415@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Stephen Frost wrote:
-- Start of PGP signed section.
> * Bruce Momjian (pgman(at)candle(dot)pha(dot)pa(dot)us) wrote:
> > Stephen Frost wrote:
> > > I'll see about writing up a proper test case/schema. Looks like I'm
> > > probably most of the way there at this point, really. ;)
> >
> > I wasn't aware you could throw binary values into the timestamp fields
> > like that. I thought you needed to use a C string for the value.
> >
> > Does PREPARE bypass that for some reason?
>
> I don't think so.. As I recall, I think I might have had it set up w/o
> using a prepare before and it was working but I'm not sure. It's
> certainly very useful and lets me bypass *alot* of overhead
> (converting to a string and then making the database convert back...).

Considering all the other things the database is doing, I can't imagine
that would be a measurable improvement.

> The one complaint I do have is that I don't see a way to pass a
> timestamp w/ an explicit timezone in binary format into a table which
> has a 'timestamp with timezone' field. I can pass a binary timestamp
> into a 'timestamp with timezone' field, but it's interpreted as UTC or
> the local timezone (can't remember which atm).

I still do not understand how this is working. It must be using our
fast path as part of prepare. What language is you client code?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Stephen Frost 2004-05-20 16:07:05 Re: Add error-checking to timestamp_recv
Previous Message Stephen Frost 2004-05-20 15:53:03 Re: Add error-checking to timestamp_recv