Re: [HACKERS] pg_dump end comment

Tom Lane wrote:
> Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> > This might seem a bit silly, but is there any chance we could add a
> > comment at the end of pg_dump text output that says '-- End of dump'?
>
> Sure --- while you're at it, put a "beginning of dump" at the start.
>
> Is it worth adding the database name and/or other command-line
> parameters given to pg_dump?
>
> One thing to think about is the difference between a bare pg_dump and a
> pg_dump/pg_restore sequence. Should these always generate identical
> text output? (They do as of CVS tip, I believe, though this was not
> always true before.)

I have added code to print end-of-dump markers for pg_dump and
pg_dumpall:

--
-- PostgreSQL database dump complete
--

--
-- PostgreSQL database cluster dump complete
--

This mirrors the markers used at the start of the files.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073