Re: [HACKERS] threads stuff/UnixWare

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, Zeugswetter Andreas SB SD <ZeugswetterA(at)spardat(dot)at>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] threads stuff/UnixWare
Date: 2004-05-13 23:57:09
Message-ID: 200405132357.i4DNv9E25053@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > *** src/Makefile.global.in 11 May 2004 21:57:14 -0000 1.182
> > --- src/Makefile.global.in 13 May 2004 23:03:12 -0000
> > ***************
> > *** 177,182 ****
> > --- 177,188 ----
> > CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> > endif
>
> > + # Unixware needs threads for everything that uses libpq
> > + ifeq ($(PORTNAME),unixware)
> > + CFLAGS += "$PTHREAD_CFLAGS"
> > + endif
> > +
> > +
> > # Kind-of compilers
>
> > YACC = @YACC@
>
>
> Yech. Isn't this what the Makefile.port files are for? Makefile.global
> should never contain any "#ifdef port" junk.

So we just add the thing in the template file? Yea, I can do that. I
did it there because Win32 already had something for libs. Does the
template file get included in Makefile.global? I didn't think so.

Part of the problem is we don't know if they have asked for threads at
the time we load the template file from configure, no?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-05-13 23:58:55 Re: [HACKERS] threads stuff/UnixWare
Previous Message Larry Rosenman 2004-05-13 23:53:08 Re: [HACKERS] threads stuff/UnixWare

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-05-13 23:58:55 Re: [HACKERS] threads stuff/UnixWare
Previous Message Larry Rosenman 2004-05-13 23:53:08 Re: [HACKERS] threads stuff/UnixWare