Re: [HACKERS] threads stuff/UnixWare

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, Zeugswetter Andreas SB SD <ZeugswetterA(at)spardat(dot)at>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] threads stuff/UnixWare
Date: 2004-05-13 23:46:00
Message-ID: 13108.1084491960@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> *** src/Makefile.global.in 11 May 2004 21:57:14 -0000 1.182
> --- src/Makefile.global.in 13 May 2004 23:03:12 -0000
> ***************
> *** 177,182 ****
> --- 177,188 ----
> CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> endif

> + # Unixware needs threads for everything that uses libpq
> + ifeq ($(PORTNAME),unixware)
> + CFLAGS += "$PTHREAD_CFLAGS"
> + endif
> +
> +
> # Kind-of compilers

> YACC = @YACC@

Yech. Isn't this what the Makefile.port files are for? Makefile.global
should never contain any "#ifdef port" junk.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-05-13 23:52:56 Re: [HACKERS] threads stuff/UnixWare
Previous Message Tom Lane 2004-05-13 23:43:45 Re: Bogus permissions display in 7.4

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-13 23:52:56 Re: [HACKERS] threads stuff/UnixWare
Previous Message Larry Rosenman 2004-05-13 23:28:14 Re: [HACKERS] threads stuff/UnixWare