Re: mingw regression test fixes

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: claudio(dot)natoli(at)memetrics(dot)com, pgsql-patches(at)postgresql(dot)org
Subject: Re: mingw regression test fixes
Date: 2004-05-02 20:17:51
Message-ID: 200405022217.51229.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian wrote:
> OK, I have made this adjustment. Thanks.

$build_platform would be more correct. It keeps everything consistent.

>
> ---------------------------------------------------------------------
>------
>
> Andrew Dunstan wrote:
> > Claudio Natoli said:
> > > For application to HEAD.
> > >
> > > As Andrew Dunstan appears to have cracked the regression test
> > > buffering nut, this patch makes sure that:
> > > * correct platform specific regression files are used under ming
> > > * pwd prints out a usable win32 pathname
> >
> > Claudio,
> >
> > I'm assuming that you have checked that this works, as it is
> > slightly different from what I did.
> >
> > Strictly speaking, the pwd flags test should probably depend in the
> > test platform rather than the target platform. Something like:
> >
> > case `uname` in
> > MINGW32*)
> > PWDFLAGS=-W;;
> > *)
> > PWDFLAGS=;;
> > esac
> >
> > I made that adjustment to what I was doing late in the day, but
> > didn't have time to do a revised patch before I had to do other
> > things.
> >
> > cheers
> >
> > andrew
> >
> >
> >
> >
> > ---------------------------(end of
> > broadcast)--------------------------- TIP 7: don't forget to
> > increase your free space map settings

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-02 21:30:34 Re: mingw regression test fixes
Previous Message Andrew Dunstan 2004-05-02 18:36:44 Re: win32 build and test issues