Re: mingw regression test fixes

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: claudio(dot)natoli(at)memetrics(dot)com, pgsql-patches(at)postgresql(dot)org
Subject: Re: mingw regression test fixes
Date: 2004-05-02 10:24:55
Message-ID: 200405021024.i42AOta11342@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


OK, I have made this adjustment. Thanks.

---------------------------------------------------------------------------

Andrew Dunstan wrote:
> Claudio Natoli said:
> >
> > For application to HEAD.
> >
> > As Andrew Dunstan appears to have cracked the regression test buffering
> > nut, this patch makes sure that:
> > * correct platform specific regression files are used under ming
> > * pwd prints out a usable win32 pathname
>
> Claudio,
>
> I'm assuming that you have checked that this works, as it is slightly
> different from what I did.
>
> Strictly speaking, the pwd flags test should probably depend in the test
> platform rather than the target platform. Something like:
>
> case `uname` in
> MINGW32*)
> PWDFLAGS=-W;;
> *)
> PWDFLAGS=;;
> esac
>
> I made that adjustment to what I was doing late in the day, but didn't
> have time to do a revised patch before I had to do other things.
>
> cheers
>
> andrew
>
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2004-05-02 13:11:53 Re: new aggregate functions v1
Previous Message Fabien COELHO 2004-05-02 09:14:19 Re: new aggregate functions v1