| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Larry Rosenman <ler(at)lerctr(dot)org>, John Siracusa <siracusa(at)mindspring(dot)com>, Postgres Performance <pgsql-performance(at)postgresql(dot)org> |
| Subject: | Re: Feature request: smarter use of conditional indexes |
| Date: | 2004-03-08 17:55:36 |
| Message-ID: | 200403081755.i28Htau25541@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-performance |
Tom Lane wrote:
> Larry Rosenman <ler(at)lerctr(dot)org> writes:
> > Just a suggestion, please use diff -c format, as it makes it easier for
> > the folks who apply the patches to do so.
>
> That's not just a suggestion ... patches that aren't in diff -c (or at
> least diff -u) format will be rejected out of hand. Without the context
> lines provided by these formats, applying a patch is an exercise in
> risk-taking, because you can't be certain that you are applying the same
> patch the submitter intended.
Also, when you get 'fuzz' output when applying the patch, you should
review the patch to make sure it appeared in the right place. That has
gotten me a few times.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-03-08 18:08:32 | Re: raising the default default_statistics_target |
| Previous Message | Joe Conway | 2004-03-08 17:43:03 | Re: question about selecting across multiple dbs |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Smith | 2004-03-08 21:43:40 | Re: simple query join |
| Previous Message | Andrew Sullivan | 2004-03-08 16:46:34 | Re: Using bigint needs explicit cast to use the index |