From: | Kurt Roeckx <Q(at)ping(dot)be> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Philip Yarra <philip(at)utiba(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: OSF build broken |
Date: | 2003-07-07 06:30:41 |
Message-ID: | 20030707063041.GA18871@ping.be |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jul 07, 2003 at 01:46:21AM -0400, Tom Lane wrote:
> Philip Yarra <philip(at)utiba(dot)com> writes:
> > And on RedHat 7.3 it's in stdint.h - they must move it around to keep the
> > snipers guessing.
>
> Sometimes it seems that way :-(
>
> > What's the best (most portable) way to fix this?
>
> My vote is to rip out every last reference to int64_t and other
> system-header-dependent datatypes. These were added in the recent
> IPv6 changes, and I thought at the time that they'd not stand the
> test of portability, but I kept quiet for lack of evidence. Now
> there is some. I recommend sending in a patch that replaces int64_t
> with int64, and likewise for anything you don't see defined or used
> in src/include/c.h. The stuff in c.h has been through the wars
> already, the IPv6 code has not.
I used int64_t because that's standard (C99). But int64 will do
too.
Kurt
From | Date | Subject | |
---|---|---|---|
Next Message | Philip Yarra | 2003-07-07 06:40:35 | Re: OSF build broken |
Previous Message | Tom Lane | 2003-07-07 05:49:48 | Re: regressions tests on freebsd/alpha: failure |